Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer API: Create identity deletion process as owner; create identity deletion process as support; deletion process approval #523

Merged
merged 103 commits into from
Feb 16, 2024
Merged

Consumer API: Create identity deletion process as owner; create identity deletion process as support; deletion process approval #523

merged 103 commits into from
Feb 16, 2024

Conversation

tnotheis
Copy link
Member

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

tnotheis and others added 30 commits October 23, 2023 13:49
@tnotheis
wip
c8f49b2
@NikolaVetnic
wip
f7eec90
@NikolaVetnic
chore: imports fixed
f413525
@NikolaVetnic
fix: some ref error with FakeItEasy
6ca6628
@NikolaVetnic
chore: extracted IdentDeletionProcessId from the Identity class
5673bea
@stamenione
feat: start deletion process as support
5f92a18
@tnotheis
Merge branch 'main' into trigger-identity-deletion-process
267fbbc
@tnotheis
refactor: introduce public Hasher
7c6f8d2
@tnotheis
feat: StartDeletionProcess handler happy path
8814e5c
@NikolaDmitrasinovic
feat: publish integration event and throw NotFoundException
21874de
@HunorTotBagi
feat: canOnlyStartDeletionProcessForOwnIdentity
59e5ec6
@NikolaVetnic
chore: cleanup
f2522a9
@NikolaVetnic
refactoring: method extracted
7a9110d
@NikolaVetnic
refactoring: extract handler creation to static methods
070fc74
@NikolaVetnic
feat: start deletion process as support
a42a8cc
@tnotheis
test: add Consumer API integration test
5628008
@NikolaVetnic
Merge branch 'trigger-identity-deletion-process' of github.com:nmshd/…
b2e8b31 
…backbone into trigger-identity-deletion-process
@tnotheis
refactor: use constructor instead of factory method for IdentityDelet…
4d8ffbd 
…ionProcessAuditLogEntry
@NikolaVetnic
chore: fix typos and unnecessary whitespaces
e8ae923
@NikolaVetnic
Merge branch 'trigger-identity-deletion-process' of github.com:nmshd/…
2164b12 
…backbone into trigger-identity-deletion-process
@tnotheis
feat: add migration
b64f184
@tnotheis
feat: add consumer api route for starting a deletion process
f1c66c6
@tnotheis
Merge branch 'trigger-identity-deletion-process' of github.com:nmshd/…
3f9addc 
…backbone into trigger-identity-deletion-process
@NikolaVetnic
test: add deletion process to identity that already has active deleti…
0fb16f3 
…on process
@tnotheis
chore: fix formatting
5b0966c
@Dannyps
fix: test not marked as Integration
3552538
@daniel-almeida-konkconsulting
Merge branch 'main' into identity-deletion
b5f54aa
@daniel-almeida-konkconsulting
Merge branch 'trigger-identity-deletion-process' into identity-deletion
5782e02
@tnotheis
test: refactor to directly assert varying outcomes
13e5fa3
@tnotheis
feat: automatically approve deletion process if started by owner
e771880
tnotheis and others added 22 commits February 13, 2024 08:45
@tnotheis
chore: fix security issue
0fb2daf
@tnotheis
fix: check for null in SeedQueuedForDeletionTierCommand Handler
467920a
@mergify
Merge branch 'main' into identity-deletion
f20d293
@tnotheis
chore: formatting
ef79051
@tnotheis
Merge branch 'identity-deletion' of github.com:nmshd/backbone into id…
2bf631e 
…entity-deletion
@tnotheis
Merge branch 'main' of github.com:nmshd/backbone
ae3fe3a
@tnotheis
Merge branch 'main' into identity-deletion
540f565
@daniel-almeida-konkconsulting @Dannyps
@NikolaVetnic @mergify @tnotheis
Deletion process approval (#462)
d73e7da 
* feat: add handler for deletion process waiting for approval reminder

* refactor: change messages in audit log and change validation when sending reminders

* test: add more unit test cases for identity deletion process approval reminders after fixing the methods

* refactor: restructure handler to account for scenarios where multiple reminders would be sent and only one should be

* test: update unit tests after refactoring

* chore: add reminders migrations

* feat: add approve deletion process command and unit tests

* chore: add missing migrations

* refactor: adjust approve deletion process handler to receive and validate de deletion process

* feat: command should return deletion process. Add Integration event and refactor existing folder structure.

* feat: add integration events for external event propagation

* fix: approved at in command response can never be null

* fix: changes after merging with base branch

* refactor: remove unnecessary setters

* refactor: switch the order of parameters

* refactor: return Ok instead of Created

* refactor: use generic NoDeletionProcessWithRequiredStatusExists for deletion process in an incorrect status

* refactor: remove unused errors

* refactor: move the status check to IdentityDeletionProcess.Approve method

* refactor: update the error message as requested in the PR

* feat: trigger integration event for tier change

* refactor: update ctor to take tier ids directly

* refactor: remove unnecessary tiers repository calls

* refactor: instantiate integration event with tier ids

* chore: remove unused directives

* refactor: modify integration event instantiation to take in tier ids directly

* chore: modify tests to instantiate integration events using tier ids directly

* feat: trigger the integration event for the tier change

* feat: set tier id and status when set to be deleted

* test: add dummy IEventBus

* test: update assertion to the new error code

* test: introduce additional assertions related to tier id and status

* chore: rename variable

* chore: rename method

* chore: reduce payload to contain only the necessary information

* refactor: remove unnecessary fields

* feat: add TierBeforeDeletionId property

* feat: add migration which adds TierBeforeDeletionId column to Identity table

* chore: fix formatting

* chore: rename class properties to better reflect what they are

* chore: rename TierBeforeDeletionId to TierIdBeforeDeletion

* feat: do not trigger PeerIdentityToBeDeletedIntegrationEvent due to data protection reasons

* chore: do not change tier when deletion process started by support

* chore: update incoming integration event property names

* chore: fix failing ci/cd tests

* chore: update migration so that TierIdBeforeDeletion column is added to Identities table

* chore: fix formatting

* chore: use Dummy instead of Fake

* refactor: use DeletionProcessId instead of string

* test: fix failing tests

* refactor: use IdentityDeletionProcessId.Value

* test: use valid form of IdentityDeletionProcessId

* test: update IdentityDeletionProcessId value

* refactor: remove duplicate code

* feat: throw exception if IdentityDeletionProcessId input string is not valid

* chore: use IdentityDeletionProcessId directly

* refactor: use identityDeletionProcessIdResult.Error

---------

Co-authored-by: Daniel Silva <[email protected]>
Co-authored-by: Nikola Vetnić <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Timo Notheisen <[email protected]>
@mergify
Merge branch 'main' into identity-deletion
48be11f
@NikolaVetnic
chore: remove migrations to be merged
ae83b9e
@NikolaVetnic
chore: merge migrations related to identity deletion
e2e4a6f
@NikolaVetnic
chore: update model snapshots
3846ba8
@NikolaVetnic
chore: fix formatting
7a5c081
@mergify
Merge branch 'main' into identity-deletion
76b683e
@mergify
Merge branch 'main' into identity-deletion
c92e103
@tnotheis
chore: improve http error when quota is exhausted
761af2d
@tnotheis
refactor: rename test
dfe7a16
@tnotheis
fix: avoid deferred execution when adding tier quota definitions
d51de61
@tnotheis
fix: read identity as tracking
22bf879
@tnotheis
Merge branch 'main' into identity-deletion
9e44bc1
@tnotheis
test: comment out test for creating a deletion process to avoid error…
bc2afb0 
… in following tests due to missing quota
@tnotheis
test: set deletion time correctly
0d1157c
@tnotheis tnotheis changed the title Identity deletion Create identity deletion process as owner; create identity deletion process as support; deletion process approval Feb 16, 2024
@tnotheis tnotheis requested a review from jkoenig134 February 16, 2024 14:55
@tnotheis tnotheis enabled auto-merge (squash) February 16, 2024 14:55
@tnotheis tnotheis merged commit bd2e143 into main Feb 16, 2024
14 checks passed
@tnotheis tnotheis deleted the identity-deletion branch February 16, 2024 15:55
@tnotheis tnotheis changed the title Create identity deletion process as owner; create identity deletion process as support; deletion process approval Consumer API: Create identity deletion process as owner; create identity deletion process as support; deletion process approval Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tnotheis @jkoenig134 @NikolaVetnic @stamenione @NikolaDmitrasinovic @HunorTotBagi @Dannyps @daniel-almeida-konkconsulting @JLSRKonk