-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consumer API: Lockout user after repeated failed login attempts #525
Consumer API: Lockout user after repeated failed login attempts #525
Conversation
…ttempts are made within 1 hour
…peated-failed-login-attempts
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test whether the lockout functionality is actually enabled for new users?
Modules/Devices/src/Devices.Application/Users/Commands/SeedTestUsers/Handler.cs
Outdated
Show resolved
Hide resolved
This reverts commit b0783cf.
Readiness checklist
Description
ServiceCollectionExtensions
now has added lockout configuration, allowing the locking out of user account for the duration of 10 minutes if 3 consecutive failed login attempts were made.UserLockedOut()
is now used to return correct error and description in case of user's locked out state.LockoutEnabled
set totrue
is added to test users in order test and showcase the functionality.