Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin UI: Initialize flutter setup #547

Merged
merged 81 commits into from
Mar 15, 2024
Merged

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Mar 5, 2024

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Copy link

coderabbitai bot commented Mar 5, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@tnotheis
Copy link
Member

tnotheis commented Mar 5, 2024

I close it until it is fully implemented, to keep the PR overview clean.

@tnotheis tnotheis closed this Mar 5, 2024
tnotheis
tnotheis previously approved these changes Mar 14, 2024
Copy link
Member

@tnotheis tnotheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkoenig134 I skimmed the new files and I think I'm okay with it. But you should give your final Go before we merge. (and maybe we should make a real PR out of this draft 😉)

@jkoenig134
Copy link
Member Author

But you should give your final Go before we merge.

I'll add my review ASAP. Is this now ready for review and nothing will be added?

@tnotheis
Copy link
Member

I'll add my review ASAP. Is this now ready for review and nothing will be added?

As soon as we discussed the config.json topic, yes. But imo you can already mark it as ready for review.

@tnotheis
Copy link
Member

We will add the Dockerfile and the corresponding build and publish pipelines in a separate PR.

@jkoenig134 jkoenig134 marked this pull request as ready for review March 14, 2024 13:57
@tnotheis tnotheis changed the title Initialize flutter setup Admin UI: Initialize flutter setup Mar 15, 2024
@jkoenig134 jkoenig134 enabled auto-merge (squash) March 15, 2024 09:06
@jkoenig134 jkoenig134 merged commit c840c4d into main Mar 15, 2024
15 checks passed
@jkoenig134 jkoenig134 deleted the initialize-flutter-setup branch March 15, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants