Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hint to the error message of the error.platform.recordNotFound regarding a potentially incorrect password #950

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add a hint to the error message of the error.platform.recordNotFound regarding a potentially incorrect password #950

merged 1 commit into from
Nov 26, 2024

Conversation

tnotheis
Copy link
Member

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@tnotheis tnotheis added the chore Some routine work like updating dependencies label Nov 26, 2024
@tnotheis tnotheis requested a review from Magnus-Kuhn November 26, 2024 11:10
@tnotheis tnotheis self-assigned this Nov 26, 2024
@tnotheis tnotheis changed the title Add a description to the error message of the error.platform.recordNotFound error that gives a hint regarding a potentially incorrect password Add a hint to the error message of the error.platform.recordNotFound regarding a potentially incorrect password Nov 26, 2024
@tnotheis tnotheis enabled auto-merge (squash) November 26, 2024 11:14
Magnus-Kuhn
Magnus-Kuhn approved these changes Nov 26, 2024
View reviewed changes
Copy link

@Magnus-Kuhn Magnus-Kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally didn't want to have the password warning show up for things that have nothing to do with passwords, but I guess it's consistent with expired record warnings showing up for things that can't expire. So I think it's fine.

@tnotheis
Copy link
Member Author

Yeah, I didn't like it at first either. But the alternative would require a lot of effort, which isn't worth it just to get a slightly better error message.

@tnotheis tnotheis requested a review from jkoenig134 November 26, 2024 12:43
@tnotheis tnotheis merged commit c3e6e16 into main Nov 26, 2024
26 checks passed
@tnotheis tnotheis deleted the add-wrong-password-description-to-recordNotFound-error branch November 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@Magnus-Kuhn Magnus-Kuhn Magnus-Kuhn approved these changes

Assignees

@tnotheis tnotheis

Labels
chore Some routine work like updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnotheis @jkoenig134 @Magnus-Kuhn