-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI for sending announcements to all identities #955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ui-for-sending-announcements
…g in create announcement dialog
jkoenig134
reviewed
Feb 25, 2025
Applications/AdminUi/packages/admin_api_sdk/lib/src/enums/severity_type.dart
Outdated
Show resolved
Hide resolved
jkoenig134
reviewed
Feb 25, 2025
Applications/AdminUi/packages/admin_api_sdk/lib/src/types/languages.dart
Outdated
Show resolved
Hide resolved
jkoenig134
reviewed
Feb 25, 2025
Applications/AdminUi/packages/admin_api_types/lib/src/announcements/create_announcement.dart
Outdated
Show resolved
Hide resolved
jkoenig134
reviewed
Feb 25, 2025
...i/apps/admin_ui/lib/home/announcements_overview/modals/show_announcement_details_dialog.dart
Outdated
Show resolved
Hide resolved
jkoenig134
reviewed
Feb 25, 2025
...AdminUi/apps/admin_ui/lib/home/announcements_overview/modals/create_announcement_dialog.dart
Outdated
Show resolved
Hide resolved
jkoenig134
reviewed
Feb 25, 2025
...AdminUi/apps/admin_ui/lib/home/announcements_overview/modals/create_announcement_dialog.dart
Outdated
Show resolved
Hide resolved
…elated exports and API response handling
…ity and maintainability
jkoenig134
reviewed
Feb 25, 2025
...AdminUi/apps/admin_ui/lib/home/announcements_overview/modals/create_announcement_dialog.dart
Show resolved
Hide resolved
jkoenig134
reviewed
Feb 25, 2025
...tions/AdminUi/packages/admin_api_types/lib/src/announcements/announcement_severity_type.dart
Outdated
Show resolved
Hide resolved
jkoenig134
reviewed
Feb 25, 2025
Applications/AdminUi/packages/admin_api_sdk/lib/src/endpoints/announcements_endpoint.dart
Outdated
Show resolved
Hide resolved
jkoenig134
reviewed
Feb 25, 2025
Applications/AdminUi/packages/admin_api_types/lib/src/announcements/announcements_overview.dart
Outdated
Show resolved
Hide resolved
e0956de
to
b5dd06f
Compare
jkoenig134
previously approved these changes
Feb 25, 2025
This will need a massive re-write. But it's ok for now. |
jkoenig134
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Announcement Overview:
Announcement Details:
Announcement Creation with required fields check:
The only thing that is a litte bit ugly is the DropDownMenu as the focus for the search leaves weird.