Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for sending announcements to all identities #955

Merged
merged 79 commits into from
Feb 25, 2025

Conversation

tnotheis
Copy link
Member

@tnotheis tnotheis commented Nov 29, 2024

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Announcement Overview:

image

Announcement Details:

image

Announcement Creation with required fields check:

image

The only thing that is a litte bit ugly is the DropDownMenu as the focus for the search leaves weird.

@tnotheis tnotheis added enhancement New feature or request wip Work in Progress labels Nov 29, 2024
@tnotheis tnotheis changed the title Admin UI for sending announcements UI for sending announcements to all identities Nov 29, 2024
@tnotheis tnotheis assigned Siolto and unassigned nicole-eb Jan 23, 2025
@tnotheis tnotheis removed the wip Work in Progress label Feb 4, 2025
@Siolto Siolto marked this pull request as ready for review February 25, 2025 09:03
@Siolto Siolto requested a review from jkoenig134 as a code owner February 25, 2025 09:03
@Siolto Siolto requested review from aince42 and nicole-eb February 25, 2025 09:03
@Siolto Siolto force-pushed the ui-for-sending-announcements branch from e0956de to b5dd06f Compare February 25, 2025 11:15
jkoenig134
jkoenig134 previously approved these changes Feb 25, 2025
@jkoenig134
Copy link
Member

This will need a massive re-write. But it's ok for now.

@tnotheis tnotheis merged commit 6daf5b7 into main Feb 25, 2025
22 checks passed
@tnotheis tnotheis deleted the ui-for-sending-announcements branch February 25, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants