Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize blob storage configuration #991

Merged
merged 12 commits into from
Dec 17, 2024
Merged

Conversation

tnotheis
Copy link
Member

@tnotheis tnotheis commented Dec 17, 2024

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

The following changes were made to the configuration:

  • Removed property: Modules.Files.Infrastructure.BlobStorage.CloudProvider
  • Removed property: Modules.Files.Infrastructure.BlobStorage.ConnectionInfo
  • Removed property: Modules.Files.Infrastructure.BlobStorage.ContainerName
  • New property: Modules.Files.Infrastructure.BlobStorage.ProductName. Can be one of the following values: AzureStorageAccount, GoogleCloudStorage
  • New property: Modules.Files.Infrastructure.BlobStorage.AzureStorageAccount.ConnectionString (required if ProductName is AzureStorageAccount)
  • New property: Modules.Files.Infrastructure.BlobStorage.AzureStorageAccount.ContainerName (required if ProductName is AzureStorageAccount)
  • New property: Modules.Files.Infrastructure.BlobStorage.GoogleCloudStorage.ServiceAccountJson (required if ProductName is GoogleCloudStorage and if there are no default credentials configured)
  • New property: Modules.Files.Infrastructure.BlobStorage.GoogleCloudStorage.BucketName (required if ProductName is GoogleCloudStorage)

@tnotheis tnotheis added chore Some routine work like updating dependencies wip Work in Progress labels Dec 17, 2024
@tnotheis tnotheis self-assigned this Dec 17, 2024
@tnotheis tnotheis added refactoring Refactoring of code and removed chore Some routine work like updating dependencies labels Dec 17, 2024
@tnotheis tnotheis force-pushed the optimize-blob-storage-configuration branch from 24bd98c to 8d500b1 Compare December 17, 2024 08:54
@tnotheis tnotheis marked this pull request as ready for review December 17, 2024 13:00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (13)
  • .ci/appsettings.override.postgres.docker.json: Language not supported
  • .ci/appsettings.override.postgres.local.json: Language not supported
  • .ci/appsettings.override.sqlserver.docker.json: Language not supported
  • .ci/appsettings.override.sqlserver.local.json: Language not supported
  • Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/api.appsettings.local.override.json: Language not supported
  • appsettings.override.json: Language not supported
  • docker-compose/.env: Language not supported
  • docker-compose/appsettings.override.json: Language not supported
  • BuildingBlocks/src/BuildingBlocks.Infrastructure/Persistence/BlobStorage/BlobStorageHealthCheck.cs: Evaluated as low risk
  • Modules/Files/src/Files.ConsumerApi/Configuration.cs: Evaluated as low risk
  • docker-compose/docker-compose.services.yml: Evaluated as low risk
  • Modules/Files/src/Files.ConsumerApi/FilesModule.cs: Evaluated as low risk
  • BuildingBlocks/test/BuildingBlocks.Infrastructure.Tests/Tests/AzureStorageAccountTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)

BuildingBlocks/src/BuildingBlocks.Infrastructure/Persistence/BlobStorage/GoogleCloudStorage/GoogleCloudStorageServiceCollectionExtensions.cs:28

  • The property 'ServiceAccountJson' is marked as required but is nullable. It should not be nullable if it is required.
public required string? ServiceAccountJson { get; set; }

Modules/Files/src/Files.Infrastructure/Persistence/IServiceCollectionExtensions.cs:25

  • Ensure that the new behavior of using RootFolder instead of Container is covered by tests.
services.Configure<BlobOptions>(blobOptions => blobOptions.RootFolder = options.BlobStorageOptions.RootFolder);
@tnotheis tnotheis merged commit f1ab551 into main Dec 17, 2024
23 checks passed
@tnotheis tnotheis deleted the optimize-blob-storage-configuration branch December 17, 2024 13:08
@tnotheis tnotheis removed the wip Work in Progress label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants