-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize blob storage configuration #991
Conversation
…o specific ServiceCollectionExtensions
# Conflicts: # docker-compose/adminui.appsettings.override.json
24bd98c
to
8d500b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (13)
- .ci/appsettings.override.postgres.docker.json: Language not supported
- .ci/appsettings.override.postgres.local.json: Language not supported
- .ci/appsettings.override.sqlserver.docker.json: Language not supported
- .ci/appsettings.override.sqlserver.local.json: Language not supported
- Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/api.appsettings.local.override.json: Language not supported
- appsettings.override.json: Language not supported
- docker-compose/.env: Language not supported
- docker-compose/appsettings.override.json: Language not supported
- BuildingBlocks/src/BuildingBlocks.Infrastructure/Persistence/BlobStorage/BlobStorageHealthCheck.cs: Evaluated as low risk
- Modules/Files/src/Files.ConsumerApi/Configuration.cs: Evaluated as low risk
- docker-compose/docker-compose.services.yml: Evaluated as low risk
- Modules/Files/src/Files.ConsumerApi/FilesModule.cs: Evaluated as low risk
- BuildingBlocks/test/BuildingBlocks.Infrastructure.Tests/Tests/AzureStorageAccountTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
BuildingBlocks/src/BuildingBlocks.Infrastructure/Persistence/BlobStorage/GoogleCloudStorage/GoogleCloudStorageServiceCollectionExtensions.cs:28
- The property 'ServiceAccountJson' is marked as required but is nullable. It should not be nullable if it is required.
public required string? ServiceAccountJson { get; set; }
Modules/Files/src/Files.Infrastructure/Persistence/IServiceCollectionExtensions.cs:25
- Ensure that the new behavior of using
RootFolder
instead ofContainer
is covered by tests.
services.Configure<BlobOptions>(blobOptions => blobOptions.RootFolder = options.BlobStorageOptions.RootFolder);
Readiness checklist
The following changes were made to the configuration:
Modules.Files.Infrastructure.BlobStorage.CloudProvider
Modules.Files.Infrastructure.BlobStorage.ConnectionInfo
Modules.Files.Infrastructure.BlobStorage.ContainerName
Modules.Files.Infrastructure.BlobStorage.ProductName
. Can be one of the following values:AzureStorageAccount
,GoogleCloudStorage
Modules.Files.Infrastructure.BlobStorage.AzureStorageAccount.ConnectionString
(required ifProductName
isAzureStorageAccount
)Modules.Files.Infrastructure.BlobStorage.AzureStorageAccount.ContainerName
(required ifProductName
isAzureStorageAccount
)Modules.Files.Infrastructure.BlobStorage.GoogleCloudStorage.ServiceAccountJson
(required ifProductName
isGoogleCloudStorage
and if there are no default credentials configured)Modules.Files.Infrastructure.BlobStorage.GoogleCloudStorage.BucketName
(required ifProductName
isGoogleCloudStorage
)