chore/upgrade dependencies (#180)

* chore: bump dependencies * chore: remove unnecessary type assertion and no if exeptions * chore: remove unnecessary type assertion * chore: update rule to match ci and local --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Julian König <[email protected]>
nmshd · Jul 9, 2024 · 4410155 · 4410155
1 parent 363a89e
commit 4410155
Show file tree

Hide file tree

Showing 11 changed files with 94 additions and 204 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -22,6 +22,7 @@
                 ]
             }
         ],
-        "jest/max-nested-describe": ["error", { "max": 4 }]
+        "jest/max-nested-describe": ["error", { "max": 4 }],
+        "jest/no-conditional-in-test": "warn"
     }
 }
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -54,5 +54,6 @@
     "files.eol": "\n",
     "typescript.unstable": {
         "organizeImportsIgnoreCase": true
-    }
+    },
+    "typescript.tsdk": "node_modules/typescript/lib"
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -26,10 +26,10 @@
         "test:teardown": "docker compose -f .dev/compose.yml down -fsv"
     },
     "devDependencies": {
-        "@js-soft/eslint-config-ts": "^1.6.8",
+        "@js-soft/eslint-config-ts": "^1.6.9",
         "@js-soft/license-check": "^1.0.9",
         "@types/jest": "^29.5.12",
-        "@types/node": "^20.14.3",
+        "@types/node": "^20.14.9",
         "enhanced-publish": "^1.1.3",
         "eslint": "^8.57.0",
         "jest": "^29.7.0",
@@ -40,6 +40,6 @@
         "ts-jest": "^29.1.5",
         "ts-node": "^10.9.2",
         "tsconfig-paths": "^4.2.0",
-        "typescript": "^5.4.5"
+        "typescript": "^5.5.3"
     }
 }
diff --git a/packages/consumption/src/modules/requests/outgoing/OutgoingRequestsController.ts b/packages/consumption/src/modules/requests/outgoing/OutgoingRequestsController.ts
@@ -190,10 +190,10 @@ export class OutgoingRequestsController extends ConsumptionBaseController {
 
     private async _setDeletionInfo(request: Request) {
         const requestItemsFromRequest = request.items.filter((item) => item instanceof RequestItem) as RequestItem[];
-        const requestItemGroupsFromRequest = request.items.filter((item) => item instanceof RequestItemGroup) as RequestItemGroup[];
+        const requestItemGroupsFromRequest = request.items.filter((item) => item instanceof RequestItemGroup);
         const requestItemsFromGroups = requestItemGroupsFromRequest.map((group) => group.items).flat();
         const requestItems = [...requestItemsFromRequest, ...requestItemsFromGroups];
-        const deleteAttributeRequestItems = requestItems.filter((item) => item instanceof DeleteAttributeRequestItem) as DeleteAttributeRequestItem[];
+        const deleteAttributeRequestItems = requestItems.filter((item) => item instanceof DeleteAttributeRequestItem);
         if (deleteAttributeRequestItems.length === 0) return;
 
         const ownSharedAttributeIds = deleteAttributeRequestItems.map((item) => item.attributeId);

diff --git a/packages/iql/test/default.test.ts b/packages/iql/test/default.test.ts
@@ -162,7 +162,7 @@ test("Check validity", () => {
 
     for (const e of table) {
         const result = iql.validate(e.iqlQuery);
-        // eslint-disable-next-line jest/no-if
+        // eslint-disable-next-line jest/no-conditional-in-test
         expect(result.isValid, `IQL query "${e.iqlQuery}" is unexepectedly ${e.isValid ? "invalid" : "valid"}.`).toBe(e.isValid);
     }
 });

diff --git a/packages/runtime/test/modules/AttributeListenerModule.test.ts b/packages/runtime/test/modules/AttributeListenerModule.test.ts
@@ -107,7 +107,7 @@ describe("AttributeListenerModule", () => {
 });
 
 function expectShareAttributeRequestItemWith(attribute: IdentityAttributeJSON | RelationshipAttributeJSON) {
-    const event = recipient.eventBus.publishedEvents.find((e) => e instanceof OutgoingRequestCreatedEvent) as OutgoingRequestCreatedEvent | undefined;
+    const event = recipient.eventBus.publishedEvents.find((e) => e instanceof OutgoingRequestCreatedEvent);
     expect(event).toBeDefined();
 
     const request = event!.data;

diff --git a/packages/transport/src/modules/accounts/IdentityDeletionProcessController.ts b/packages/transport/src/modules/accounts/IdentityDeletionProcessController.ts
@@ -99,7 +99,7 @@ export class IdentityDeletionProcessController extends TransportController {
     public async getIdentityDeletionProcesses(): Promise<IdentityDeletionProcess[]> {
         return (await this.identityDeletionProcessCollection.find())
             .map((identityDeletionProcess) => (identityDeletionProcess ? IdentityDeletionProcess.from(identityDeletionProcess) : undefined))
-            .filter((identityDeletionProcess) => !!identityDeletionProcess) as IdentityDeletionProcess[];
+            .filter((identityDeletionProcess) => !!identityDeletionProcess);
     }
 
     public async getIdentityDeletionProcessByStatus(...identityDeletionProcessStatus: IdentityDeletionProcessStatus[]): Promise<IdentityDeletionProcess | undefined> {

diff --git a/packages/transport/test/modules/PublicAPI.test.ts b/packages/transport/test/modules/PublicAPI.test.ts
@@ -173,7 +173,7 @@ function testPublicFunctions(controllerName: string) {
         let found = 0;
         for (const functionName of publicFunctions[controllerName]) {
             const item = controllers[controllerName][functionName];
-            // eslint-disable-next-line jest/no-if
+            // eslint-disable-next-line jest/no-conditional-in-test
             if (!item || typeof item !== "function") continue;
             found++;
         }

diff --git a/packages/transport/test/utils/Random.test.ts b/packages/transport/test/utils/Random.test.ts
@@ -15,7 +15,7 @@ describe("RandomTest", function () {
             const iterations = 10000;
             for (let i = 1; i < iterations; i++) {
                 const n = await Random.intBetween(0, 1);
-                // eslint-disable-next-line jest/no-if
+                // eslint-disable-next-line jest/no-conditional-in-test
                 switch (n) {
                     case 0:
                         buckets[0]++;
@@ -136,7 +136,7 @@ describe("RandomTest", function () {
 
             for (let i = 1; i < iterations; i++) {
                 const n = await Random.string(1, RandomCharacterRange.Alphabet);
-                // eslint-disable-next-line jest/no-if
+                // eslint-disable-next-line jest/no-conditional-in-test
                 if (buckets[n]) buckets[n]++;
                 else buckets[n] = 1;
             }

diff --git a/packages/transport/test/utils/Reflection.test.ts b/packages/transport/test/utils/Reflection.test.ts
@@ -105,7 +105,7 @@ describe("ReflectionTest", function () {
         const reflectionKeys = Reflect.getMetadataKeys(Serializable, "types");
         const notFoundClasses: string[] = [];
         for (const className of cryptoClassNames) {
-            // eslint-disable-next-line jest/no-if
+            // eslint-disable-next-line jest/no-conditional-in-test
             if (!reflectionKeys.includes(className)) {
                 notFoundClasses.push(className);
             }
@@ -118,7 +118,7 @@ describe("ReflectionTest", function () {
         const notFoundClasses: string[] = [];
 
         for (const className of transportClassNames) {
-            // eslint-disable-next-line jest/no-if
+            // eslint-disable-next-line jest/no-conditional-in-test
             if (!reflectionKeys.includes(className)) {
                 notFoundClasses.push(className);
             }