chore: PR comments

packages/consumption/src/modules/attributes/AttributesController.ts

@@ -1296,6 +1296,6 @@ export class AttributesController extends ConsumptionBaseController {
 
     public async getAttributeTagCollection(): Promise<AttributeTagCollection> {
         const backboneAttributeTagCollection = (await this.attributeTagClient.getBackboneAttributeTagCollection()).value;
-        return AttributeTagCollection.fromAny(backboneAttributeTagCollection);
+        return AttributeTagCollection.from(backboneAttributeTagCollection);
     }
 }

packages/consumption/src/modules/attributes/local/AttributeTagCollection.ts

@@ -1,18 +1,32 @@
 import { Serializable, serialize, type, validate } from "@js-soft/ts-serval";
 
+export interface IAttributeTagCollection {
+    supportedLanguages: string[];
+    tagsForAttributeValueTypes: Record<string, Record<string, IAttributeTag>>;
+}
+
+export interface IAttributeTag {
+    displayNames: Record<string, string>;
+    children?: Record<string, IAttributeTag>;
+}
+
 @type("AttributeTagCollection")
-export class AttributeTagCollection extends Serializable {
+export class AttributeTagCollection extends Serializable implements IAttributeTagCollection {
     @serialize({ type: String })
     @validate()
     public supportedLanguages: string[];
 
     @serialize()
     @validate()
     public tagsForAttributeValueTypes: Record<string, Record<string, AttributeTag>>;
+
+    public static from(value: IAttributeTagCollection): AttributeTagCollection {
+        return this.fromAny(value);
+    }
 }
 
 @type("AttributeTag")
-export class AttributeTag extends Serializable {
+export class AttributeTag extends Serializable implements IAttributeTag {
     @serialize()
     @validate()
     public displayNames: Record<string, string>;

packages/runtime/src/useCases/consumption/attributes/GetAttributeTagCollection.ts

@@ -11,7 +11,7 @@ export class GetAttributeTagCollectionUseCase extends UseCase<void, AttributeTag
     }
 
     protected async executeInternal(): Promise<Result<AttributeTagCollectionDTO>> {
-        const tagList = await this.attributesController.getAttributeTagCollection();
-        return Result.ok(AttributeTagCollectionMapper.toAttributeTagCollectionDTO(tagList));
+        const attributeTagCollection = await this.attributesController.getAttributeTagCollection();
+        return Result.ok(AttributeTagCollectionMapper.toAttributeTagCollectionDTO(attributeTagCollection));
     }
 }

packages/transport/src/modules/index.ts

@@ -115,8 +115,8 @@ export * from "./sync/DatawalletModificationsProcessor";
 export * from "./sync/local/DatawalletModification";
 export * from "./sync/SyncController";
 export * from "./sync/SynchronizedCollection";
-export * from "./tags/backbone/BackboneGetTag";
-export * from "./tags/backbone/TagClient";
+export * from "./tags/backbone/AttributeTagClient";
+export * from "./tags/backbone/BackboneGetAttributeTagCollection";
 export * from "./tokens/AnonymousTokenController";
 export * from "./tokens/backbone/BackboneGetTokens";
 export * from "./tokens/backbone/BackbonePostTokens";

packages/transport/src/modules/tags/backbone/TagClient.ts → packages/transport/src/modules/tags/backbone/AttributeTagClient.ts

@@ -1,9 +1,9 @@
 import { ClientResult } from "../../../core/backbone/ClientResult";
 import { RESTClientAuthenticate } from "../../../core/backbone/RESTClientAuthenticate";
-import { BackboneAttributeTagCollection } from "./BackboneGetTag";
+import { BackboneGetAttributeTagCollection } from "./BackboneGetAttributeTagCollection";
 
 export class AttributeTagClient extends RESTClientAuthenticate {
-    public async getBackboneAttributeTagCollection(): Promise<ClientResult<BackboneAttributeTagCollection>> {
-        return await this.get<BackboneAttributeTagCollection>("/api/v1/Tags");
+    public async getBackboneAttributeTagCollection(): Promise<ClientResult<BackboneGetAttributeTagCollection>> {
+        return await this.get<BackboneGetAttributeTagCollection>("/api/v1/Tags");
     }
 }

packages/transport/src/modules/tags/backbone/BackboneGetAttributeTagCollection.ts

@@ -0,0 +1,9 @@
+export interface BackboneGetAttributeTagCollection {
+    supportedLanguages: string[];
+    tagsForAttributeValueTypes: Record<string, Record<string, BackboneGetAttributeTag>>;
+}
+
+interface BackboneGetAttributeTag {
+    displayNames: Record<string, string>;
+    children?: Record<string, BackboneGetAttributeTag>;
+}