feat: clean up PR

nmshd · Oct 21, 2024 · 64d1a38 · 64d1a38
1 parent 7af1f3e
commit 64d1a38
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/packages/consumption/src/modules/attributes/AttributesController.ts b/packages/consumption/src/modules/attributes/AttributesController.ts
@@ -554,7 +554,6 @@ export class AttributesController extends ConsumptionBaseController {
             content: parsedSuccessorParams.content,
             succeeds: predecessorId,
             shareInfo: parsedSuccessorParams.shareInfo,
-            // TODO: remove parentId or add isDefault (maybe also in other places)
             parentId: parsedSuccessorParams.parentId,
             createdAt: parsedSuccessorParams.createdAt,
             succeededBy: parsedSuccessorParams.succeededBy
@@ -910,8 +909,7 @@ export class AttributesController extends ConsumptionBaseController {
             succeeds: parsedSuccessorParams.succeeds,
             succeededBy: parsedSuccessorParams.succeededBy,
             shareInfo: parsedSuccessorParams.shareInfo,
-            parentId: parsedSuccessorParams.parentId,
-            isDefault: parsedSuccessorParams.isDefault
+            parentId: parsedSuccessorParams.parentId
         });
 
         if (!predecessor.isThirdPartyRelationshipAttribute()) {

diff --git a/packages/consumption/src/modules/attributes/local/AttributeSuccessorParams.ts b/packages/consumption/src/modules/attributes/local/AttributeSuccessorParams.ts
@@ -44,10 +44,6 @@ export class AttributeSuccessorParams extends Serializable implements IAttribute
     @serialize()
     public parentId?: CoreId;
 
-    @validate({ nullable: true })
-    @serialize()
-    public isDefault?: true;
-
     public static from(value: IAttributeSuccessorParams | AttributeSuccessorParamsJSON): AttributeSuccessorParams {
         return this.fromAny(value);
     }