Feature/Make tags optional for LocalAttributeDVOs (#139)

* feat: make tags of LocalAttributeDVOs optional * test: SharedToPeerAttributeDVO * chore: version bump * fix: adjust IQLQueryExpanded test
nmshd · May 27, 2024 · b808959 · b808959
1 parent 77472ce
commit b808959
Show file tree

Hide file tree

Showing 6 changed files with 135 additions and 109 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/runtime/package.json b/packages/runtime/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@nmshd/runtime",
-    "version": "4.9.0",
+    "version": "4.9.1",
     "description": "The enmeshed client runtime.",
     "homepage": "https://enmeshed.eu",
     "repository": {

diff --git a/packages/runtime/src/dataViews/DataViewExpander.ts b/packages/runtime/src/dataViews/DataViewExpander.ts
@@ -1142,7 +1142,7 @@ export class DataViewExpander {
                     isDraft: false,
                     requestReference: localAttribute.shareInfo.requestReference?.toString(),
                     notificationReference: localAttribute.shareInfo.notificationReference?.toString(),
-                    tags: identityAttribute.tags ? identityAttribute.tags : [],
+                    tags: identityAttribute.tags,
                     valueType,
                     deletionStatus: localAttribute.deletionInfo?.deletionStatus,
                     deletionDate: localAttribute.deletionInfo?.deletionDate.toString()
@@ -1168,7 +1168,7 @@ export class DataViewExpander {
                 requestReference: localAttribute.shareInfo.requestReference?.toString(),
                 notificationReference: localAttribute.shareInfo.notificationReference?.toString(),
                 sourceAttribute: localAttribute.shareInfo.sourceAttribute?.toString(),
-                tags: identityAttribute.tags ? identityAttribute.tags : [],
+                tags: identityAttribute.tags,
                 valueType,
                 deletionStatus: localAttribute.deletionInfo?.deletionStatus,
                 deletionDate: localAttribute.deletionInfo?.deletionDate.toString()
@@ -1196,7 +1196,7 @@ export class DataViewExpander {
             isOwn: true,
             isDraft: false,
             sharedWith: sharedToPeerDVOs as SharedToPeerAttributeDVO[],
-            tags: identityAttribute.tags ? identityAttribute.tags : [],
+            tags: identityAttribute.tags,
             valueType
         };
     }

diff --git a/packages/runtime/src/dataViews/consumption/LocalAttributeDVO.ts b/packages/runtime/src/dataViews/consumption/LocalAttributeDVO.ts
@@ -33,7 +33,7 @@ export interface RepositoryAttributeDVO extends LocalAttributeDVO {
     type: "RepositoryAttributeDVO";
     sharedWith: SharedToPeerAttributeDVO[];
     isOwn: true;
-    tags: string[];
+    tags?: string[];
 }
 
 /**
@@ -46,7 +46,7 @@ export interface SharedToPeerAttributeDVO extends LocalAttributeDVO {
     notificationReference?: string;
     sourceAttribute?: string;
     isOwn: true;
-    tags: string[];
+    tags?: string[];
     deletionDate?: string;
     deletionStatus?: string;
 }
@@ -60,7 +60,7 @@ export interface PeerAttributeDVO extends LocalAttributeDVO {
     requestReference?: string;
     notificationReference?: string;
     isOwn: false;
-    tags: string[];
+    tags?: string[];
     deletionDate?: string;
     deletionStatus?: string;
 }

diff --git a/packages/runtime/test/dataViews/IQLQueryExpanded.test.ts b/packages/runtime/test/dataViews/IQLQueryExpanded.test.ts
@@ -103,7 +103,7 @@ describe("IQLQueryExpanded", () => {
         const givenName = dvo.value as AbstractStringJSON;
         expect(givenName["@type"]).toBe("GivenName");
         expect(givenName.value).toBe("Hugo");
-        expect(dvo.tags[0]).toBe("default");
+        expect(dvo.tags![0]).toBe("default");
         expect(dvo.createdAt).toStrictEqual(attribute.createdAt);
         expect(dvo.isOwn).toBe(true);
         expect(dvo.isValid).toBe(true);
@@ -150,7 +150,7 @@ describe("IQLQueryExpanded", () => {
         const value3 = dvo.value as AbstractStringJSON;
         expect(value3["@type"]).toBe("GivenName");
         expect(value3.value).toBe("Tester");
-        expect(dvo.tags[0]).toBe("fake");
+        expect(dvo.tags![0]).toBe("fake");
         expect(dvo.createdAt).toStrictEqual(attribute.createdAt);
         expect(dvo.isOwn).toBe(true);
         expect(dvo.isValid).toBe(true);
@@ -195,7 +195,7 @@ describe("IQLQueryExpanded", () => {
         const givenName = dvo.value as AbstractStringJSON;
         expect(givenName["@type"]).toBe("GivenName");
         expect(givenName.value).toBe("Hugo");
-        expect(dvo.tags[0]).toBe("default");
+        expect(dvo.tags![0]).toBe("default");
         expect(dvo.createdAt).toStrictEqual(attribute.createdAt);
         expect(dvo.isOwn).toBe(true);
         expect(dvo.isValid).toBe(true);
@@ -240,7 +240,7 @@ describe("IQLQueryExpanded", () => {
         const givenName = dvo.value as AbstractStringJSON;
         expect(givenName["@type"]).toBe("GivenName");
         expect(givenName.value).toBe("Tester");
-        expect(dvo.tags[0]).toBe("fake");
+        expect(dvo.tags![0]).toBe("fake");
         expect(dvo.createdAt).toStrictEqual(attribute.createdAt);
         expect(dvo.isOwn).toBe(true);
         expect(dvo.isValid).toBe(true);
@@ -282,7 +282,7 @@ describe("IQLQueryExpanded", () => {
         const givenName = dvo.value as AbstractStringJSON;
         expect(givenName["@type"]).toBe("GivenName");
         expect(givenName.value).toBe("Tester");
-        expect(dvo.tags[0]).toBe("fake");
+        expect(dvo.tags![0]).toBe("fake");
         expect(dvo.createdAt).toStrictEqual(attribute.createdAt);
         expect(dvo.isOwn).toBe(true);
         expect(dvo.isValid).toBe(true);
@@ -306,7 +306,7 @@ describe("IQLQueryExpanded", () => {
         const value = dvo.value as AbstractStringJSON;
         expect(value["@type"]).toBe("Surname");
         expect(value.value).toBe("Nachname");
-        expect(dvo.tags[0]).toBe("fake");
+        expect(dvo.tags![0]).toBe("fake");
         expect(dvo.createdAt).toStrictEqual(attribute.createdAt);
         expect(dvo.isOwn).toBe(true);
         expect(dvo.isValid).toBe(true);