Skip to content

Commit

Permalink
chore: remove backbone from client method name
Browse files Browse the repository at this point in the history
  • Loading branch information
sebbi08 committed Dec 4, 2024
1 parent 8768d9d commit d394750
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,7 @@ export class AttributesController extends ConsumptionBaseController {
}

public async getAttributeTagCollection(): Promise<AttributeTagCollection> {
const backboneAttributeTagCollection = (await this.attributeTagClient.getBackboneAttributeTagCollection()).value;
const backboneAttributeTagCollection = (await this.attributeTagClient.getAttributeTagCollection()).value;
return AttributeTagCollection.from(backboneAttributeTagCollection);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe("AttributeTagCollection", function () {
});

test("should receive the legal tags from the Backbone", async function () {
when(mockedClient.getBackboneAttributeTagCollection()).thenResolve(ClientResult.ok(mockTags));
when(mockedClient.getAttributeTagCollection()).thenResolve(ClientResult.ok(mockTags));
const tags = await consumptionController.attributes.getAttributeTagCollection();

expect(tags.toJSON()).toStrictEqualExcluding(mockTags, "@type");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe("get attributeTagCollection", function () {
/* eslint-enable @typescript-eslint/naming-convention */

test("should receive the legal tags from the Backbone", async function () {
when(mockedRestClient.getBackboneAttributeTagCollection()).thenResolve(ClientResult.ok(mockTags));
when(mockedRestClient.getAttributeTagCollection()).thenResolve(ClientResult.ok(mockTags));
const tags = await runtimeService.consumption.attributes.getAttributeTagCollection();

expect(tags.value).toStrictEqual(mockTags);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { RESTClientAuthenticate } from "../../../core/backbone/RESTClientAuthent
import { BackboneGetAttributeTagCollection } from "./BackboneGetAttributeTagCollection";

export class AttributeTagClient extends RESTClientAuthenticate {
public async getBackboneAttributeTagCollection(): Promise<ClientResult<BackboneGetAttributeTagCollection>> {
public async getAttributeTagCollection(): Promise<ClientResult<BackboneGetAttributeTagCollection>> {
return await this.get<BackboneGetAttributeTagCollection>("/api/v1/Tags");
}
}

0 comments on commit d394750

Please sign in to comment.