test: RequestConfigs

nmshd · Sep 12, 2024 · fb44c78 · fb44c78
1 parent ce3245c
commit fb44c78
Show file tree

Hide file tree

Showing 2 changed files with 850 additions and 190 deletions.
diff --git a/packages/runtime/src/modules/DeciderModule.ts b/packages/runtime/src/modules/DeciderModule.ts
@@ -51,6 +51,7 @@ export class DeciderModule extends RuntimeModule<DeciderModuleConfiguration> {
         }
     }
 
+    // TODO: we could add a validation that the requestConfig itself is valid too, e.g. if an IdentityAttribute is expected, it doesn't have properties of a RelationshipAttribute set
     public validateAutomationConfig(requestConfig: RequestConfig, responseConfig: ResponseConfig): boolean {
         if (isRejectResponseConfig(responseConfig)) return true;
-Original file line number
+Diff line change
@@ Expand Up @@
             }
         }
+        // TODO: we could add a validation that the requestConfig itself is valid too, e.g. if an IdentityAttribute is expected, it doesn't have properties of a RelationshipAttribute set
         public validateAutomationConfig(requestConfig: RequestConfig, responseConfig: ResponseConfig): boolean {
             if (isRejectResponseConfig(responseConfig)) return true;
@@ Expand Down @@