Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correlation ID to all use cases and send it to backbone #268

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Sep 11, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@sebbi08 sebbi08 added the enhancement New feature or request label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
packages/runtime/src/useCases/common/UseCase.ts 73.19% <100.00%> (+2.08%) ⬆️
packages/transport/src/core/backbone/RESTClient.ts 74.30% <100.00%> (+0.36%) ⬆️

@Milena-Czierlinski
Copy link
Contributor

I'm not sure if adding a newline actually counts as updating a test. :D Is there a way we can truly test this feature?

jkoenig134
jkoenig134 previously approved these changes Sep 12, 2024
@jkoenig134
Copy link
Member

Is there a way we can truly test this feature?

there should be a way. But I think it would require some mocking of the rest client.

@sebbi08
Copy link
Contributor Author

sebbi08 commented Sep 12, 2024

I added some test but forgot to add the file :/

@jkoenig134
Copy link
Member

jkoenig134 commented Sep 13, 2024

@sebbi08 we don't need correlation IDs for every UseCase? My hope would be to have one in the whole runtime scope to also be able to use it in the app.

@sebbi08
Copy link
Contributor Author

sebbi08 commented Sep 13, 2024

@sebbi08 we don't need correlation IDs for every UseCase? My hope would be to have one in the whole runtime scope to also be able to use it in the app.

Ah, i see. The problem I see with this is that we cannot distinguish between the different actions of a user in one session, as all will have the same. Or are you creating a new runtime for each action?

@jkoenig134
Copy link
Member

I don't, but why do we have to create a new runtime when we create correlation id's for each usecase?

@sebbi08 sebbi08 force-pushed the feature/add_correlation_id branch from 8844664 to 1992e38 Compare September 13, 2024 07:05
@sebbi08
Copy link
Contributor Author

sebbi08 commented Sep 13, 2024

Ok never mind, I forgot to push my work

@sebbi08 sebbi08 changed the title Send correlation id to backbone Add correlation ID to all use cases and send it to backbone Sep 13, 2024
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to check something within the correlation-id lib

@sebbi08 sebbi08 merged commit 8510f91 into main Sep 13, 2024
17 checks passed
@sebbi08 sebbi08 deleted the feature/add_correlation_id branch September 13, 2024 11:31
@jkoenig134 jkoenig134 mentioned this pull request Sep 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants