-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add correlation ID to all use cases and send it to backbone #268
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
I'm not sure if adding a newline actually counts as updating a test. :D Is there a way we can truly test this feature? |
there should be a way. But I think it would require some mocking of the rest client. |
I added some test but forgot to add the file :/ |
Co-authored-by: Julian König <[email protected]>
Co-authored-by: Julian König <[email protected]>
@sebbi08 we don't need correlation IDs for every UseCase? My hope would be to have one in the whole runtime scope to also be able to use it in the app. |
Ah, i see. The problem I see with this is that we cannot distinguish between the different actions of a user in one session, as all will have the same. Or are you creating a new runtime for each action? |
I don't, but why do we have to create a new runtime when we create correlation id's for each usecase? |
8844664
to
1992e38
Compare
Ok never mind, I forgot to push my work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to check something within the correlation-id lib
Readiness checklist