Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expectThrowsAsync #277

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Remove expectThrowsAsync #277

merged 5 commits into from
Sep 20, 2024

Conversation

Milena-Czierlinski
Copy link
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@Milena-Czierlinski Milena-Czierlinski added the refactoring Refactoring of code label Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@jkoenig134 jkoenig134 added wip Work in Progress (blocks mergify from auto update the branch) test This pull request contains only new or changed tests and removed refactoring Refactoring of code labels Sep 19, 2024
@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review September 19, 2024 16:33
@Milena-Czierlinski Milena-Czierlinski removed the wip Work in Progress (blocks mergify from auto update the branch) label Sep 19, 2024
jkoenig134
jkoenig134 previously approved these changes Sep 20, 2024
View reviewed changes
@Milena-Czierlinski Milena-Czierlinski enabled auto-merge (squash) September 20, 2024 15:32
@Milena-Czierlinski Milena-Czierlinski merged commit 390ea01 into main Sep 20, 2024
17 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the refactor/remove-expectthrowsasync branch September 20, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Assignees
No one assigned
Labels
test This pull request contains only new or changed tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Milena-Czierlinski @jkoenig134