Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove relationshipRequest naming #292

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Remove relationshipRequest naming #292

merged 3 commits into from
Oct 8, 2024

Conversation

jkoenig134
Copy link
Member

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description

Add support for nmshd/backbone#904.

@jkoenig134 jkoenig134 added bug Something isn't working refactoring Refactoring of code and removed bug Something isn't working labels Oct 8, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/modules/relationships/RelationshipsController.ts 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...c/modules/relationships/RelationshipsController.ts 86.28% <0.00%> (ø)

@jkoenig134 jkoenig134 requested a review from sebbi08 October 8, 2024 09:10
@jkoenig134 jkoenig134 enabled auto-merge (squash) October 8, 2024 09:14
@jkoenig134 jkoenig134 merged commit 6a46d44 into main Oct 8, 2024
18 checks passed
@jkoenig134 jkoenig134 deleted the remove-relationshipRequest-naming branch October 8, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebbi08 sebbi08 sebbi08 approved these changes

@tnotheis tnotheis tnotheis approved these changes

@Magnus-Kuhn Magnus-Kuhn Awaiting requested review from Magnus-Kuhn

Assignees
No one assigned
Labels
refactoring Refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoenig134 @sebbi08 @tnotheis