Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve address regex #294

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Improve address regex #294

merged 4 commits into from
Oct 11, 2024

Conversation

Magnus-Kuhn
Copy link
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@Magnus-Kuhn Magnus-Kuhn added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Oct 10, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
packages/runtime/src/useCases/common/Schemas.ts 100.00% <100.00%> (ø)
...c/useCases/common/validation/ValidatableStrings.ts 100.00% <100.00%> (ø)

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 10, 2024
View reviewed changes
@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review October 10, 2024 14:46
@Magnus-Kuhn Magnus-Kuhn removed the wip Work in Progress (blocks mergify from auto update the branch) label Oct 10, 2024
@jkoenig134
Copy link
Member

@stnmtz please recheck, but regex seems to be fine: https://regex101.com/r/vSszsd/1

@Magnus-Kuhn Magnus-Kuhn merged commit eaf4c1f into main Oct 11, 2024
18 checks passed
@Magnus-Kuhn Magnus-Kuhn deleted the improve-address-regex branch October 11, 2024 12:24
@jkoenig134 jkoenig134 mentioned this pull request Oct 11, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@stnmtz stnmtz stnmtz approved these changes

@sebbi08 sebbi08 Awaiting requested review from sebbi08

@slavistan slavistan Awaiting requested review from slavistan

@tnotheis tnotheis Awaiting requested review from tnotheis

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Magnus-Kuhn @jkoenig134 @stnmtz