Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make addressGenerationHostnameOverride configurable for tests #297

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Make addressGenerationHostnameOverride configurable for tests #297

merged 1 commit into from
Oct 16, 2024

Conversation

jkoenig134
Copy link
Member

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@jkoenig134 jkoenig134 added chore Some routine work like updating dependencies test This pull request contains only new or changed tests labels Oct 16, 2024
@jkoenig134 jkoenig134 requested a review from tnotheis October 16, 2024 06:25
@jkoenig134 jkoenig134 enabled auto-merge (squash) October 16, 2024 06:25
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@jkoenig134 jkoenig134 merged commit 968643d into main Oct 16, 2024
21 checks passed
@jkoenig134 jkoenig134 deleted the chore/make-addressGenerationHostnameOverride-configurable-for-tests branch October 16, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis approved these changes

Assignees
No one assigned
Labels
chore Some routine work like updating dependencies test This pull request contains only new or changed tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoenig134 @tnotheis