Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for undefined parentId of shared Attributes #302

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Add check for undefined parentId of shared Attributes #302

merged 1 commit into from
Oct 18, 2024

Conversation

Milena-Czierlinski
Copy link
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@Milena-Czierlinski Milena-Czierlinski added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Oct 18, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...ion/src/modules/attributes/local/LocalAttribute.ts 96.29% <100.00%> (+0.11%) ⬆️

@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review October 18, 2024 14:12
@jkoenig134 jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Oct 18, 2024
@Milena-Czierlinski Milena-Czierlinski merged commit a500474 into main Oct 18, 2024
22 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the feature/parent-id-in-typeguards branch October 18, 2024 14:29
@jkoenig134
Copy link
Member

@Milena-Czierlinski I wanted to create the release, then I saw that you ticked I ensured that the PR title is good enough for the changelog. but still have Feature/ in the title. Please only mark things as done that are really done!

@jkoenig134 jkoenig134 changed the title Feature/Add check for undefined parentId of shared Attributes Add check for undefined parentId of shared Attributes Oct 23, 2024
@jkoenig134 jkoenig134 added refactoring Refactoring of code and removed enhancement New feature or request labels Oct 23, 2024
@Milena-Czierlinski
Copy link
Contributor Author

Oh no, I (again) forgot that we don't do this any longer. 😞 I vow to do better!

@jkoenig134
Copy link
Member

I also flagged is a refactoring b/c it's not really a feature for the user of the runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Assignees
No one assigned
Labels
refactoring Refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Milena-Czierlinski @jkoenig134