Multiple open Requests that lead to a Relationship can exist for the same Identity

[jkoenig134]

Readiness checklist

• I added/updated tests.
• I ensured that the PR title is good enough for the changelog.
• I labeled the PR.

[jkoenig134]

@stnmtz & @tnotheis maybe you also want to look over this.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/runtime/src/modules/RequestModule.ts	0.00%	23 Missing ⚠️

Files with missing lines	Coverage Δ
packages/runtime/src/modules/RequestModule.ts	56.68% <0.00%> (-4.07%)	⬇️

[britsta]

I realized a while ago that some validation takes place in the modules, although it should actually take place at a deeper level. Otherwise, if no modules are used and the methods are called manually, strange things can happen. In the case of this validation, I would expect it to be included in the received method of the IncomingRequestsController.

[jkoenig134]

@britsta all these validations (including the new one I've added) are checking things that are important for RequestModule logic.

To make this clearer using an example: the consumption library doesn’t care at all if there is a Relationship or another open Request because it doesn't decides how the response is sent out.

[britsta]

@britsta all these validations (including the new one I've added) are checking things that are important for RequestModule logic.

To make this clearer using an example: the consumption library doesn’t care at all if there is a Relationship or another open Request because it doesn't decides how the response is sent out.

No matter we have still validation in the modules or not, how can we ensure the correctness of the processes in case an integrator isn't using the modules? We still need the option to add the appropriate validation for this case.

[jkoenig134]

We don't, but when the integrator doesn't uses the Modules there are many other problems.

[jkoenig134]

how can we ensure the correctness of the processes in case an integrator isn't using the modules

Also - when the integrator doesn't use the modules, then he's not using our process and their process could be valid.

[britsta]

@jkoenig134 Mhh alright, let's discuss this again somewhere else. :D For the moment, the newly added validation can stay with the other validation in the Module. 👼

Does not need to be discussed in this PR.

[jkoenig134]

Thanks master 😅

[britsta]

Thanks master 😅

@jkoenig134 It's been a long time since anyone has referred to me as master of disaster 👀