Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circular dependency #310

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Remove circular dependency #310

merged 2 commits into from
Oct 24, 2024

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Oct 24, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@sebbi08 sebbi08 added the chore Some routine work like updating dependencies label Oct 24, 2024
@sebbi08 sebbi08 marked this pull request as ready for review October 24, 2024 09:30
@sebbi08 sebbi08 requested a review from jkoenig134 October 24, 2024 09:30
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
packages/runtime/src/modules/DeciderModule.ts 94.01% <100.00%> (+0.01%) ⬆️
.../consumption/attributes/GetRepositoryAttributes.ts 100.00% <100.00%> (ø)

... and 206 files with indirect coverage changes

@sebbi08 sebbi08 enabled auto-merge (squash) October 24, 2024 11:01
@sebbi08 sebbi08 merged commit c8b6b35 into main Oct 24, 2024
18 checks passed
@sebbi08 sebbi08 deleted the feature/resolve_circular_dependencies branch October 24, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski approved these changes

Assignees
No one assigned
Labels
chore Some routine work like updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebbi08 @jkoenig134 @Milena-Czierlinski