Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Template resolver from IncomingRequestsController #312

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Remove unused Template resolver from IncomingRequestsController #312

merged 1 commit into from
Oct 24, 2024

Conversation

Magnus-Kuhn
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn commented Oct 24, 2024 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@Magnus-Kuhn Magnus-Kuhn added wip Work in Progress (blocks mergify from auto update the branch) refactoring Refactoring of code labels Oct 24, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...nsumption/src/consumption/ConsumptionController.ts 96.72% <100.00%> (-0.02%) ⬇️
...es/requests/incoming/IncomingRequestsController.ts 96.63% <ø> (-0.03%) ⬇️

@Magnus-Kuhn Magnus-Kuhn removed the wip Work in Progress (blocks mergify from auto update the branch) label Oct 24, 2024
@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review October 24, 2024 10:50
@Magnus-Kuhn Magnus-Kuhn merged commit 22cbba8 into main Oct 24, 2024
22 checks passed
@Magnus-Kuhn Magnus-Kuhn deleted the remove-template-resolver branch October 24, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Assignees
No one assigned
Labels
refactoring Refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Magnus-Kuhn @jkoenig134