Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS Certificate Pinning #314

Closed
wants to merge 3 commits into from
Closed

TLS Certificate Pinning #314

wants to merge 3 commits into from

Conversation

Magnus-Kuhn
Copy link
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@Magnus-Kuhn Magnus-Kuhn added the enhancement New feature or request label Oct 28, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.80645% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/transport/src/core/Transport.ts 28.00% 18 Missing ⚠️
packages/transport/src/core/TransportCoreErrors.ts 16.66% 5 Missing ⚠️
Files with missing lines Coverage Δ
packages/transport/src/core/TransportCoreErrors.ts 57.70% <16.66%> (-1.12%) ⬇️
packages/transport/src/core/Transport.ts 81.36% <28.00%> (-9.82%) ⬇️

@jkoenig134 jkoenig134 changed the title Key pinning TLS Certificate Pinning Oct 28, 2024
@Magnus-Kuhn
Copy link
Contributor Author

Moving this to the Connector nmshd/connector#295

@jkoenig134 jkoenig134 deleted the key-pinning branch November 28, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 left review comments

@stnmtz stnmtz Awaiting requested review from stnmtz

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Magnus-Kuhn @jkoenig134