Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the PushNotificationModuleTest #354

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Dec 2, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

When using one EventBus for the whole test we win the flexibility to just wait for the EventBus to being finished with processing and then we can do checks.

@jkoenig134 jkoenig134 added the test This pull request contains only new or changed tests label Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@jkoenig134 jkoenig134 enabled auto-merge (squash) December 2, 2024 17:04
@jkoenig134 jkoenig134 merged commit 94bccd4 into main Dec 2, 2024
19 checks passed
@jkoenig134 jkoenig134 deleted the simplify-PushNotificationModuleTest branch December 2, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This pull request contains only new or changed tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants