Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup AccountController and Clients #360

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Dec 10, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@jkoenig134 jkoenig134 added the refactoring Refactoring of code label Dec 10, 2024
@jkoenig134 jkoenig134 enabled auto-merge (squash) December 10, 2024 12:26
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ransport/src/modules/accounts/AccountController.ts 83.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
...t/src/modules/devices/backbone/DeviceAuthClient.ts 91.66% <100.00%> (ø)
packages/transport/src/modules/index.ts 100.00% <ø> (ø)
...ransport/src/modules/accounts/AccountController.ts 87.77% <83.33%> (-0.09%) ⬇️

@jkoenig134 jkoenig134 merged commit e3f38c8 into main Dec 10, 2024
19 checks passed
@jkoenig134 jkoenig134 deleted the refactor-accountcontroller branch December 10, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants