Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPEC] support neon enable option #2481

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[SPEC] support neon enable option #2481

merged 1 commit into from
Feb 23, 2024

Conversation

jihochu
Copy link
Contributor

@jihochu jihochu commented Feb 22, 2024

It supports enable_neon only when aarch64 architecture.
And, neon option can be selectable for aarch64.

Signed-off-by: Jiho Chu [email protected]

@taos-ci
Copy link

taos-ci commented Feb 22, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2481. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link

taos-ci commented Feb 22, 2024

:octocat: cibot: @jihochu, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2481-202402221135440.11998891830444-635d97f8dfc5f365734523962e37bf96ff3443ad/.

@jihochu
[SPEC] support neon enable option
d0eb596 
It supports enable_neon only when aarch64 architecture.
And, neon option can be selectable for aarch64.

Signed-off-by: Jiho Chu <[email protected]>
taos-ci
taos-ci approved these changes Feb 22, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihochu, 💯 All CI checkers are successfully verified. Thanks.

DonghakPark
DonghakPark approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@myungjoo myungjoo merged commit 789f07b into nnstreamer:main Feb 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo approved these changes

@taos-ci taos-ci taos-ci approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@skykongkong8 skykongkong8 Awaiting requested review from skykongkong8 skykongkong8 is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jihochu @taos-ci @myungjoo @DonghakPark