[Wait For #2854][FSU] Modify SimpleFC Application for FSU-CPU Test @open sesame 02/10 14:56 #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonghakPark
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang,
dkjung and
haehun
as code owners
DonghakPark
force-pushed
the
fsu_cpu_Application
branch
from
ec4e82c to
d9d1cf6
Compare
DonghakPark
force-pushed
the
fsu_cpu_Application
branch
from
d9d1cf6 to
5074334
Compare
DonghakPark
changed the title
jijoongmoon
reviewed
Feb 10, 2025
djeong20
reviewed
Feb 10, 2025
DonghakPark
force-pushed
the
fsu_cpu_Application
branch
from
3f8c249 to
b5324b3
Compare
dkjung
approved these changes
Feb 11, 2025
Applications/SimpleFC/jni/main.cpp
Outdated
|
|
||
| for (unsigned int j = 0; j < feature_size; ++j) | ||
| input[j] = j; | ||
| input[j] = (j / feature_size); |
There was a problem hiding this comment.
This is just the same as
input[j] = 0;because this is the integer division and all js are smaller than feature_size.
There was a problem hiding this comment.
Oh.. i see i will update, Thank you for Review
Comment on lines
+394
to
+396
| if (!((model_graph.getNumLoadedWeightPoolTensors() + 1) / 2 < | ||
| lookahead + 1)) { | ||
| model_graph.checkUnloadComplete(f - 1); |
There was a problem hiding this comment.
Just for checking:
This layer waits for the previous layer only if
!((model_graph.getNumLoadedWeightPoolTensors() + 1) / 2 < lookahead + 1)It doesn't need to wait if
(model_graph.getNumLoadedWeightPoolTensors() + 1) / 2 < lookahead + 1)
Am I correct?
There was a problem hiding this comment.
yes. this will wait unload tensor for check mem dealloc
DonghakPark
force-pushed
the
fsu_cpu_Application
branch
2 times, most recently
from
ddbf5a0 to
22aa3ea
Compare
Can find out the number of currently loaded tensors through the getNumLoadedTensors function. When LoadTensors is executed once, getNumLoadedTensors increases twice. Added the leave_lookahead argument to LoadTensors. Calculate leave_lookahead through getNumLoadedTensors and execute loadTensors. Signed-off-by: SeoHyungjun <[email protected]>
Update FSU SimpleFC Application for real case **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
at case of fsu, layer's load not needed - add swap parm - when swap enabled : load not work - update SimpleFC Application **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
Modify Application for CPU side Test **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
1. fix uint -> unsigned int 2. remove some debug cout for accurate performance record **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
Add doxygen comment on getNumLoadedTensors **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
DonghakPark
force-pushed
the
fsu_cpu_Application
branch
from
22aa3ea to
97a7dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modiy Simple FC Application for FSU-CPU Side TEST
commit summary
commit 1 [Application] Update FSU SimpleFC Application : update SimpleFC Application for more easy test & actual environment
commit 2 [FSU] update layer weight load logic at fsu : update layernode not to load weight at load()
commit 3 [FSU] Modify Application for CPU side Test : update Application
Self evaluation:
Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Donghak PARK [email protected]