[Bug] fix multi-threading issue in lstm layer #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LSTM, when the multi-thread option is enabled, either only the d_bias_h (hidden) value is calculated or both d_bias_ih (input-hidden) and d_bias_hh (hidden-hidden) values are calculated, depending on whether the integrate_bias option is set. However, there was an error because all three values were being attempted to be calculated at the same time. Therefore, this patch adds a conditional statement to fix this bug. **Self evaluation:** Build test: [x]Passed [ ]Failed [ ]Skipped Run test: [x]Passed [ ]Failed [ ]Skipped Signed-off-by: Seungbaek Hong <[email protected]>
baek2sm
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
skykongkong8,
djeong20,
EunjuYang,
dkjung and
haehun
as code owners
baek2sm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LSTM, when the multi-thread option is enabled, either only the
d_bias_h (hidden)value is calculated orboth d_bias_ih (input-hidden) and d_bias_hh (hidden-hidden)values are calculated, depending on whether the integrate_bias option is set. However, there was an error because all three values were being attempted to be calculated at the same time. Therefore, this patch adds a conditional statement to fix this bug.Self evaluation:
Build test: [x]Passed [ ]Failed [ ]Skipped
Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Seungbaek Hong [email protected]