[WIP] PathProperty -p repartion for openvino backbone and layer #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrrak
force-pushed
the
path_property
branch
from
36c99b3 to
5a08c5b
Compare
It is common to have an configuration property that includes paths, introduce new property kind; Its implementation is based on portable <filesystem> library. This frees us from path parsing, handing in cross-platform manner. Also it provides basic file operations, like creating directoris. Signed-off-by: Piotr Rak <[email protected]>
Specialized helper for file model path. Its main purpouse is to ensure file path meets criterions of given type model files. It covers PropsTflModelPath (file readability and correct file extension), while extending it to set of possible file extensions. Signed-off-by: Piotr Rak <[email protected]>
piotrrak
force-pushed
the
path_property
branch
from
676609d to
c3a4f7e
Compare
This allows to build test-suite w/o tensorflow-lite. Probably can be dropped when we'll stop using python-env provided OpenVINO.
Adds sanity tests for path property.
Fixes build with gtest as subproject.
This avoids opening file stream. Signed-off-by: Piotr Rak <[email protected]>
That should be cheap enough using stat() or alike underneath. Signed-off-by: Piotr Rak <[email protected]>
This had potential to overflow for files larger than 4GB (2^32)B This days it is bit small. This change is NOT the real fix of this potential issue, but makes it (sample_size * RawFileDataProducer::pixel_size) times less likely. The return type of this function still holds just 2^32-1. Signed-off-by: Piotr Rak <[email protected]>
Signed-off-by: Piotr Rak <[email protected]>
piotrrak
force-pushed
the
path_property
branch
from
c3a4f7e to
dfdefb1
Compare
Signed-off-by: Piotr Rak <[email protected]>
Signed-off-by: Piotr Rak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DR Description
This PR is preparation for OpenVINO backend.
PathPropertythat represents filesystem pathModelPathPropertythat facilitates checking if path points to file with given set of the file extensions.The ModelPathPropertygeneralizesnntrainer::PropsTflModelPathand will be used by OpenVINO model path property.Since OpenVINO has multiple frontends there is need to filter paths with multiple possible extensions.
In addition this allows to switch
Property<std::string>toPathPropertyand use c++17std::filesystemlibrary facilities for properties that are paths.OpenVINO frontends are:
Self evaluation:
How to evaluate:
TODOAdd signed-off message automatically by running $git commit -s ... command.
$ git push origin <your_branch_name>