[Tensor] Zero point support for unsigned int type #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeong20
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
EunjuYang,
dkjung and
haehun
as code owners
EunjuYang
reviewed
Feb 13, 2025
nntrainer/tensor/uint_tensor.cpp
Outdated
Comment on lines
506
to
512
| // copy scale factors | ||
| float *scales = (float *)(((int16_t *)buf) + size()); | ||
| scopy(scale_size(), scales, 1, (float *)getScale(), 1); | ||
|
|
||
| // copy zero points | ||
| unsigned int *zps = | ||
| (unsigned int *)((float *)(((int16_t *)buf) + size()) + scale_size()); |
There was a problem hiding this comment.
Suggested change
| // copy scale factors | |
| float *scales = (float *)(((int16_t *)buf) + size()); | |
| scopy(scale_size(), scales, 1, (float *)getScale(), 1); | |
| // copy zero points | |
| unsigned int *zps = | |
| (unsigned int *)((float *)(((int16_t *)buf) + size()) + scale_size()); | |
| // copy scale factors | |
| float *scales = (float *)(((T *)buf) + size()); | |
| scopy(scale_size(), scales, 1, (float *)getScale(), 1); | |
| // copy zero points | |
| unsigned int *zps = | |
| (unsigned int *)((float *)(((T *)buf) + size()) + scale_size()); |
There was a problem hiding this comment.
Thank you! You are the best 👍
This pull request updates the unsigned int type Tensor class to include zero points in its memory management. It's important to note that the size of the scale factors matches the size of the zero points. At present, the zero point uses a scale factor size, which will be modified soon. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
djeong20
force-pushed
the
tensor/uint/zero_point
branch
from
5783b38 to
e4a1725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the unsigned int type Tensor class to include zero points in its memory management.
It's important to note that the size of the scale factors matches the size of the zero points.
At present, the zero point uses a scale factor size, which will be modified soon.
Self-evaluation: