[Coverity] Fix Coverity issue #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonghakPark
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang,
dkjung and
haehun
as code owners
baek2sm
reviewed
Feb 12, 2025
nntrainer/tensor/int4_tensor.cpp
Outdated
| @@ -339,7 +339,7 @@ std::vector<unsigned int> Int4QTensor::argmax() const { | |||
|
|
|||
| for (unsigned int b = 0; b < batch_size; ++b) { | |||
| int8_t curr_val, max_val = -8; | |||
| unsigned int max_element_idx; | |||
| unsigned int max_element_idx = 0; | |||
There was a problem hiding this comment.
this part was modified in #2944 !
There was a problem hiding this comment.
i see, i will remove this part
1. Resolve FALL_THROUGH : Missing break at the end of case ```ml::train:TensorDim::DataType::QINT16``` at line 285 - Add break to exit the case 2. Resolve LOCAL_VAR : Uninitialized data is read from local variable max_element_idx at int4_tensor.cpp:351 - Add initialize **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
DonghakPark
force-pushed
the
defect_fix
branch
from
65ffda5 to
626e491
Compare
myungjoo
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ml::train:TensorDim::DataType::QINT16at line 285--> Add break to exit the case
--> Add initialize
Self evaluation: