Add unit-tests for dotCL function, N=1, M=1 case #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkjung
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang and
haehun
as code owners
Add the two unit-test functions - blas_kernels.dotCL_sgemv_N_1_M_1_1 - blas_kernels.dotCL_sgemv_N_1_M_1_2 They test the case such a case with `N=1, M=1`. Signed-off-by: Daekyoung Jung <[email protected]>
dkjung
force-pushed
the
feature/opencl-unit-test
branch
from
f61a3e4 to
434494e
Compare
djeong20
reviewed
Feb 26, 2025
| @@ -459,6 +459,97 @@ TEST(blas_kernels, dotCL_sgemv_n_fp16) { | |||
| EXPECT_THROW(dotCl(A_fp16, B_fp16, transA, transB), std::runtime_error); | |||
| } | |||
|
|
|||
| TEST(blas_kernels, dotCL_sgemv_N_1_M_1_1) { | |||
| setUpGpuContext(); | |||
There was a problem hiding this comment.
Do you know if we need to call this for every test? I see most of the test cases do not, but only two test cases call it. (dotCL_sgemv_M_1_1, and dotCL_sgemv_M_1_1_fp16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two unit-tests that test
dotCLAs there is no test for
dotClfunction in the case withN=1, M=1,I added two unit-tests for that condition.
Self evaluation:
How to evaluate:
./tools/android_test.shwith an Android device attached to your machineadb shell /data/local/tmp/nntr_android_test/unittest_blas_kernels_cl --gtest_filter=blas_kernels.dotCL_sgemv_N_1_M_1_*