[Router] Fix conflicted packet_rule entries
#1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Zhewen
commented
Feb 6, 2025
| @@ -210,8 +210,10 @@ | |||
| // CHECK: aie.rule(24, 0, %[[VAL_69]]) | |||
| // CHECK: } | |||
| // CHECK: aie.packet_rules(EAST : 0) { | |||
| // CHECK: aie.rule(24, 8, %[[VAL_70]]) | |||
| // CHECK: aie.rule(24, 8, %[[VAL_71]]) | |||
There was a problem hiding this comment.
This is a good example to show the issue. Previously, both rules here share the exact same condition, which is incorrect and causes data to go through the wrong arbiter.
Yu-Zhewen
force-pushed
the
zhewen_packet_rules
branch
from
a84e747 to
29e67c7
Compare
jtuyls
requested changes
Feb 10, 2025
compiler/plugins/target/AMD-AIE/aie/AMDAIECreatePathFindFlows.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/aie/AMDAIECreatePathFindFlows.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/aie/AMDAIECreatePathFindFlows.cpp
Outdated
Show resolved
Hide resolved
jtuyls
reviewed
Feb 10, 2025
jtuyls
reviewed
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each
packet_rulesoperation can contain up to four individualpacket_ruleentries. These entries must be unique and sorted in the IR, as the first matching entry takes priority.