[AssignPacketIds] Prioritize ID assignment for control packets #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Zhewen
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
jtuyls
approved these changes
Feb 10, 2025
| // normal flows. Control packet flows will be prioritized for packet ID | ||
| // assignment. | ||
| SmallVector<AMDAIE::FlowOp> ctrlPktFlowOps; | ||
| SmallVector<AMDAIE::FlowOp> normalPktFlowOps; |
There was a problem hiding this comment.
I suggestdataPktFlowOps as I think it's more descriptive.
Suggested change
| SmallVector<AMDAIE::FlowOp> normalPktFlowOps; | |
| SmallVector<AMDAIE::FlowOp> dataPktFlowOps; |
|
|
||
| // ----- | ||
|
|
||
| // Test that control packets should take priority in the ID assignment. |
There was a problem hiding this comment.
Maybe add that this can be seen in the checks by those flow ops getting packet_id == 0 assigned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of the effort to make control packet routing static.