Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UKernel] Add bf16/bfp16 ukernel for peano and move tests to peano #1114

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

jtuyls
Copy link
Collaborator

@jtuyls jtuyls commented Feb 17, 2025

No description provided.

@jtuyls jtuyls changed the title [UKernel] Add bf16 ukernel for peano and move tests to peano [UKernel] Add bf16/bfp16 ukernel for peano and move tests to peano Feb 17, 2025
@@ -1581,74 +1581,6 @@ def __init__(self):
self.existing_names = []
self.tests = []

# Tests Matmul + Trunci.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the matmul + trunci tests to reduce CI time as there are still matmul+scaling+trunci tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should then cleanup the matmul_trunci* template test and the base class ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@Abhishek-Varma Abhishek-Varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @jtuyls ! Just one question.

@@ -1581,74 +1581,6 @@ def __init__(self):
self.existing_names = []
self.tests = []

# Tests Matmul + Trunci.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should then cleanup the matmul_trunci* template test and the base class ?

@jtuyls jtuyls merged commit e9d6615 into nod-ai:main Feb 17, 2025
7 checks passed
@jtuyls jtuyls deleted the bfp16-ukernel branch February 17, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants