-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UKernel] Add bf16/bfp16 ukernel for peano and move tests to peano #1114
Conversation
@@ -1581,74 +1581,6 @@ def __init__(self): | |||
self.existing_names = [] | |||
self.tests = [] | |||
|
|||
# Tests Matmul + Trunci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the matmul + trunci tests to reduce CI time as there are still matmul+scaling+trunci tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should then cleanup the matmul_trunci*
template test and the base class ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this @jtuyls ! Just one question.
@@ -1581,74 +1581,6 @@ def __init__(self): | |||
self.existing_names = [] | |||
self.tests = [] | |||
|
|||
# Tests Matmul + Trunci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should then cleanup the matmul_trunci*
template test and the base class ?
No description provided.