[AMDAIESinkIntoCore] Generalize sinking for reuse with other regioned ops #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newling
requested review from
makslevental,
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
jtuyls
approved these changes
Feb 19, 2025
| // Replace uses of the dependency op inside the block. Specifically, | ||
| // if `use` is in `block` then replace its operand with `sunkOp`. | ||
| auto isInBlock = [&block](OpOperand &use) { | ||
| auto op = use.getOwner(); |
There was a problem hiding this comment.
Suggested change
| auto op = use.getOwner(); | |
| Operation *op = use.getOwner(); |
newling
force-pushed
the
generalize_sinking
branch
from
314497f to
4fac170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the PR to vectorize linalg.fill: #1095
Basically one of the patterns introduced in #1095 means that in one of the subsequent passes (lowering to llvm dialect) a cast operation is introduced outside of an aie.core, which needs to be inside the aie.core for core-to-standard to work. i.e. we need to sink an operation into an aie.core. Before this PR, there is already a pass to sink operations into
amdaie.core. This PR refactors that pass so that it can be reused to sink intoaie.core(or any other regioned op).