Function to estimate stack size (using existing tooling) #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newling
requested review from
makslevental,
nirvedhmeshram,
MaheshRavishankar,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
jtuyls
approved these changes
Feb 20, 2025
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/XCLBinGen.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/XCLBinGen.cpp
Outdated
Show resolved
Hide resolved
| llvm::errs() << "Failed to get upper bounds of stack sizes\n"; | ||
| return failure(); | ||
| } | ||
| auto upperBounds = std::move(maybeUpperBounds.value()); |
There was a problem hiding this comment.
Suggested change
| auto upperBounds = std::move(maybeUpperBounds.value()); | |
| llvm::DenseMap<std::pair<uint32_t, uint32_t>, uint32_t> upperBounds = std::move(maybeUpperBounds.value()); |
| llvm::errs() << "Failed to assemble ll with peano\n"; | ||
| return failure(); | ||
| } | ||
|
|
||
| // If this is not windows, we can do this check. On windows checkTool | ||
| // doesn't pipe outputs correctly. |
There was a problem hiding this comment.
outputs being the stack sizes right?
There was a problem hiding this comment.
Yeah, in runTool the piping is gated on WIN32. Specifically I think it's this redirection for windows redirects = {{}, {}, {}} which means we don't get the logging back (and I don't want to sink hours into fixing this now!)
| mlir::FailureOr<llvm::DenseMap<std::pair<uint32_t, uint32_t>, uint32_t>> | ||
| ubs = detail::getUpperBoundStackSizes(asmStr); | ||
| EXPECT_TRUE(succeeded(ubs)); | ||
| // auto upperBounds = maybeUpperBounds.value(); |
There was a problem hiding this comment.
Suggested change
| // auto upperBounds = maybeUpperBounds.value(); |
newling
force-pushed
the
stack_size_estimator_3
branch
from
b9c76d9 to
cbfb00d
Compare
newling
force-pushed
the
stack_size_estimator_3
branch
from
cbfb00d to
bb56565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace #1116 -- instead of string matching the assembly file, it uses llvm's
llvm-readelfafter adding--stack-size-sectionto the llc call.