[CONV] Pass the device and target info from the command line. - #24
Open
pashu123 wants to merge 2 commits into
Open
[CONV] Pass the device and target info from the command line.#24pashu123 wants to merge 2 commits into
pashu123 wants to merge 2 commits into
Conversation
Author
|
@kuhar Which Python formatter to use? I am unable to find the info. |
Member
|
I don't think we enforce any automatic formatting. If you want to format this, I'd submit a separate 'cleanup' PR and then land this on top of it. We can use |
Author
Done. |
added 2 commits
October 17, 2024 20:02
Black format with default option, i.e., black file_name.py. Signed-off-by: Prashant Kumar <pk5561@gmail.com>
The device and target info was hardcoded and now can be passed viacommand line to the compile command. Also, black formatted the files. Signed-off-by: Prashant Kumar <pk5561@gmail.com>
pashu123
force-pushed
the
pass_dev
branch
2 times, most recently
from
October 17, 2024 14:36
d44d9e3 to
3181239
Compare
kuhar
requested changes
Oct 17, 2024
kuhar
left a comment
kuhar
left a comment
Member
There was a problem hiding this comment.
Please open a separate PR for the formatting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device and target info was hardcoded and now can be passed via command line to the compile command.