Add KUBECONFIG environment variable validation for windows - #12
Add KUBECONFIG environment variable validation for windows#12jitesh-gupta wants to merge 2 commits into
Conversation
|
I think the goal is for the kubectl part to always work as it is part of the base kubernetes setup. Can we add to the local session but also keep the persistence in your PR? The kubeconfig part is fine for the user to always set, but it'd be nice for the user to not worry about the base kubernetes setup |
Sounds good! |
| # Exit early if KUBECONFIG is not set to a valid path | ||
| $kubeconfigPath = [System.Environment]::GetEnvironmentVariable('KUBECONFIG') | ||
| if ( -not $kubeconfigPath) { | ||
| Write-Host "KUBECONFIG is not set or empty. Exiting" |
There was a problem hiding this comment.
I thought it KUBECONFIG is not set, it'll be default to ~/.kube/config
The assumption here is KUBECONFIG has to be se. Please verify the correctness of this assumption
There was a problem hiding this comment.
From the documentation: "If the KUBECONFIG env variable doesn't exist, kubectl uses the default kubeconfig file, $HOME/.kube/config"
Because we are not giving instructions to our customers about the default kubeconfig file and are going with the KUBECONFIG environment variable route, I think we should have this check.
I am also fine with providing more instructions around the kubeconfig settings and removing this check completely.
3 participants
Similar to the changes made for linux setup: #11
Small tweak to the KUBECONFIG setup.
Issue: Noticed that setup fails if anon.conf is not present in the same directory as the setup file. This is contradictory to exposing an environment variable KUBECONFIG that can be set to a path outside of the repo as well.
Fix: Instead of checking for existence of anon.conf in the same directory as the setup script, check if KUBECONFIG is set up correctly.