Skip to content

Commit

Permalink
Unpin NumPy
Browse files Browse the repository at this point in the history
`numpy<2.0` is required for Windows with `torch<2.4`. Expanding testing
on Windows with Python 3.12 and torch 2.4.1.
  • Loading branch information
marbre committed Dec 13, 2024
1 parent 332baa3 commit 0804746
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .github/workflows/ci-sharktank.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ jobs:
- os: windows-2022
python-version: "3.11"
torch-version: "2.3.0"
- os: windows-2022
python-version: "3.12"
torch-version: "2.4.1"
exclude:
- python-version: "3.12"
# `torch.compile` requires torch>=2.4.0 for Python 3.12+
Expand Down Expand Up @@ -60,6 +63,10 @@ jobs:
path: ${{ env.PIP_CACHE_DIR }}
key: pip-${{ steps.setup_python.outputs.python-version }}-${{ hashFiles('*requirements*.txt','sharktank/requirements*.txt') }}

- name: Install numpy
if: ${{ matrix.os == 'windows-2022' && matrix.torch-version == '2.3.0' }}
run: pip install "numpy<2.0"

- name: Install pip deps
run: |
python -m pip install --no-compile --upgrade pip
Expand Down
2 changes: 1 addition & 1 deletion sharktank/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ iree-turbine

# Runtime deps.
gguf>=0.11.0
numpy<2.0
numpy

# Model deps.
huggingface-hub==0.22.2
Expand Down

0 comments on commit 0804746

Please sign in to comment.