Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLIP text model #643

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Add CLIP text model #643

merged 4 commits into from
Dec 9, 2024

Conversation

sogartar
Copy link
Contributor

@sogartar sogartar commented Dec 4, 2024

Ports the CLIP text model from Hugging Face. This is the first iteration so not much is changed from the original model. Things like dropout and checkpointing are removed.
Add numeric verification tests for the various components of the stack when executing in eager mode. Verifications are made for float32 and bfloat16. There are tests for toy-sized components and the whole model as well as the Large pretrained variant.
These tests does not include testing with IREE.

Functionalities for mask creation are not yet ported.

@sogartar sogartar force-pushed the clip-text-model branch 2 times, most recently from d658a9f to a6de6cb Compare December 4, 2024 01:47
@sogartar sogartar marked this pull request as ready for review December 4, 2024 02:16
@sogartar sogartar requested a review from rsuderman December 4, 2024 15:21
@sogartar sogartar requested a review from IanNod December 5, 2024 02:22
@sogartar sogartar force-pushed the clip-text-model branch 3 times, most recently from 526440f to 7bc98ef Compare December 9, 2024 15:05
@sogartar sogartar dismissed rsuderman’s stale review December 9, 2024 16:01

I will address model changes after adding the IREE tests so that we make refactoring while the code is under test.

Ports the CLIP text model from Hugging Face.
Add numeric verification tests for the various components of the stack
when executing in eager mode. Verifications are made for float32 and
bfloat16. There are tests for toy-sized components and the whole model
as well as the Large pretrained variant.
These tests does not include testing with IREE.

Functionalities for mask creation are not yet ported.
@sogartar sogartar enabled auto-merge (squash) December 9, 2024 16:02
@sogartar sogartar merged commit c9cb226 into nod-ai:main Dec 9, 2024
8 checks passed
monorimet pushed a commit that referenced this pull request Jan 8, 2025
Ports the CLIP text model from Hugging Face. This is the first iteration
so not much is changed from the original model. Things like dropout and
checkpointing are removed.
Add numeric verification tests for the various components of the stack
when executing in eager mode. Verifications are made for float32 and
bfloat16. There are tests for toy-sized components and the whole model
as well as the Large pretrained variant.
These tests does not include testing with IREE.

Functionalities for mask creation are not yet ported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants