Fix grok and add ToyGrok model #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hf` layout for rotary embedding was broken during a previous refactor. Readding the layout changes fixes this. This also includes a toy grok model for testing. It was validated to produce the same results for prefill and decode.
KyleHerndon
approved these changes
Dec 5, 2024
monorimet
pushed a commit
that referenced
this pull request
Jan 8, 2025
The `hf` layout for rotary embedding was broken during a previous refactor. Readding the layout changes fixes this. This also includes a toy grok model for testing. It was validated to produce the same results for prefill and decode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hflayout for rotary embedding was broken during a previous refactor. Readding the layout changes fixes this. This also includes a toy grok model for testing. It was validated to produce the same results for prefill and decode.