Trying to adapt the code to Python3+ #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2535,7 +2544,8 @@ def __init__(self): | |||
|
|
|||
| def _deepcopy(self, value): | |||
| if isinstance(value, FunctionType): | |||
| return instancemethod(value, self) | |||
| return getattr(self, value.__name__) # Replaces instancemethod(value, self) | |||
There was a problem hiding this comment.
This might be why draw() doesn't work. I noticed that value is usually (almost always?) the draw function? Might be related to why draw() doesn't actually draw anything, because i return it in the wrong way.
This is a working copy of a version that is working in the sense that it's able to install and run a basic example (without desired results?): http://i.imgur.com/7L8omha.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP copy of a version that is working in the sense that it's able to install and run a basic examples (without desired results?):
Would love to see this merged into a new branch of the official repo.
I'm well aware that some of these conversions breaks backwards compability.
canvas = Canvas()definition in./nodebox/graphics/__init__.pyconfused me a bit, couldn't get it to go global in Python3 so i just created a wrapper function that returns it from the local scope whenever called.def draw()function doesn't appear to actually draw anything, haven't really started to learn the library yet since i spent most of the day just converting old broken Py2.6 code up to speed. (not done yet perhaps).Files modified in short: