Remove reliance on .sh script #2
Conversation
This should enable cross-plattform development easily, while not requiring any special setups.
There was a problem hiding this comment.
Thank you very much for this (and your kind words)! Really glad to receive some expertise to solve Windows compatibility :)
I confirmed that (following my requested changes to keep macOS happy) this script exits and relaunches the app upon a HMR signal, and also ensures that the user can still read stdout and stderr from the app. If the app exits due to some other signal (such as pressing Ctrl + C to terminate the livereload script, or the signal raised by exiting the app via the quit action from Qt's menu), the live reload script terminates as expected.
So, no regressions, and fully functioning! If you could test whether my changes work on Windows too, then I'd be happy to merge them once applied!
Except for the handling of the disconnect signal all changes were valid and prove to work on windows.
|
Thank you for being so fast on the review. I double checked and all changes should be implemented by now. |
Forgot an s on line 7 and therefore lne 21. A friend pointed out that the "pipe" array is the default, but "inherit" automatically uses the parents process stdio.
|
Thank you for the PR! I'll add you to the contributors on |
|
Added to Svelte NodeGUI contributors in PR: nodegui/svelte-nodegui#62 |
First of all I want to say, that all of this is very impressive and I am very happy, that such a cool project exists.
I had some problems getting the project of the ground on my Windows system, which had to do with the bash script user in the start script. What I did was just a small hack, which replaces the bash script with a node script, which achieves the same thing.
This is mainly used for me, but maybe wone would want to integrate it nonetheless. I am open for further questions or anything, which may be required to get this to merge.
Have a great day.