Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: create git repo under binary_tmp user #3733

Merged
merged 1 commit into from
May 23, 2024

Conversation

richardlau
Copy link
Member

Create the binary_tmp git repository under the home directory for the binary_tmp user to avoid permissions issues encountered when previously trying to create it under the iojs user.

This change will mean that for any machines that mount expanded storage as an additional disk, the binary_tmp users' home directory will need to be on the larger storage. In practice this means that the additional disk should be mounted at /home/ rather than /home/iojs/.

Fixes: #3732

Create the `binary_tmp` git repository under the home directory for
the `binary_tmp` user to avoid permissions issues encountered when
previously trying to create it under the `iojs` user.

This change will mean that for any machines that mount expanded
storage as an additional disk, the `binary_tmp` users' home directory
will need to be on the larger storage. In practice this means that
the additional disk should be mounted at `/home/` rather than
`/home/iojs/`.
@richardlau
Copy link
Member Author

Draft while testing.

Tested on test-equinix-ubuntu2204-x64-2 (jenkins-workspace-8).

Planning to test on test-ibm-ubuntu2204-x64-3 (jenkins-workspace-6) once jobs finish running on it (as I'll need to remount the additional disk at /home/ instead of /home/iojs/).

The live binary_tmp git repository is running on test-equinix-ubuntu2204-x64-1 (jenkins-workspace-7) and I suspect the playbook with these changes will fall over as /home/binary_tmp/binary_tmp.git is a symbolic link (on the other machine(s) I've removed the link and target but if I remove the target on jenkins-workspace-7 then any in-flight fanned jobs would fail and none of the fanned jobs would be resumable). I may need to attempt to move and/or copy the git repo on this machine (~58GB) manually to the new location if we want to prevent the loss of data.

@richardlau
Copy link
Member Author

Planning to test on test-ibm-ubuntu2204-x64-3 (jenkins-workspace-6) once jobs finish running on it (as I'll need to remount the additional disk at /home/ instead of /home/iojs/).

Remounted the disk on test-ibm-ubuntu2204-x64-3 (jenkins-workspace-6) at /home/ and tested the updated playbook there.

@richardlau
Copy link
Member Author

The live binary_tmp git repository is running on test-equinix-ubuntu2204-x64-1 (jenkins-workspace-7) and I suspect the playbook with these changes will fall over as /home/binary_tmp/binary_tmp.git is a symbolic link (on the other machine(s) I've removed the link and target but if I remove the target on jenkins-workspace-7 then any in-flight fanned jobs would fail and none of the fanned jobs would be resumable). I may need to attempt to move and/or copy the git repo on this machine (~58GB) manually to the new location if we want to prevent the loss of data.

CI was quiet so I went ahead and did this:

@richardlau richardlau marked this pull request as ready for review May 20, 2024 23:31
@richardlau richardlau merged commit f5167c7 into nodejs:main May 23, 2024
1 check passed
@richardlau richardlau deleted the binary_tmp branch May 23, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jenkins-workspace tasks don't work on existing workers
2 participants