Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ansible: temporarily patch libstdc++ header on s390x" #3736

Merged
merged 1 commit into from
May 30, 2024

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented May 23, 2024

This reverts commit 9c149d0.

gcc-toolset-12 now includes the fix we were temporarily patching for.

Refs: #3659 (comment)
Refs: nodeshift/v8-build#7

This reverts commit 9c149d0.

`gcc-toolset-12` now includes the fix we were temporarily patching for.
@richardlau

This comment was marked as outdated.

@richardlau

This comment was marked as outdated.

@richardlau

This comment was marked as outdated.

@richardlau richardlau marked this pull request as ready for review May 28, 2024 16:40
@richardlau
Copy link
Member Author

richardlau commented May 28, 2024

Looks like the dnf issues are resolved.

Deploying the changes:

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit bec735f into nodejs:main May 30, 2024
1 check passed
@richardlau richardlau deleted the undo-temp-patch branch May 30, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants