Enable ccache in Windows CI #4018
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropped Clang support for Node.js v23 as ccache support landed later
richardlau
approved these changes
Feb 11, 2025
|
Since a lot of time passed since this was opened I think it is safe to merge it now. Potentially there will be some problematic PRs in the node and for those, I'll write comments to rebase on the latest main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables using
ccacheon Windows VMs in the CI if it is present and not disabled.This PR also has a fixup for #4016 as
ccachewas only enabled for MSVC (copying as cl.exe) and not for ClangCL (copying as clang-cl.exe)IMPORTANT: As
ccacheoption landed invcbuild.batin Node.js recently, we should wait some time before landing this as it may break CI runs on branches without that change