lib: reduce the length of the temporary directory path (#1089)

Refs: nodejs/node#57005 (comment)
nodejs · Feb 21, 2025 · a828b25 · a828b25
1 parent 83ffabd
commit a828b25
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/temp-directory.js b/lib/temp-directory.js
@@ -1,15 +1,15 @@
 import { join } from 'path';
 import { promises as fs, realpathSync } from 'fs';
-import { randomUUID } from 'crypto';
+import { randomBytes } from 'crypto';
 import { tmpdir } from 'os';
 
 import { removeDirectory } from './utils.js';
 
 export async function create(context) {
   if (context.options && context.options.tmpDir) {
-    context.path = join(context.options.tmpDir, randomUUID());
+    context.path = join(context.options.tmpDir, randomBytes(4).toString('hex'));
   } else {
-    context.path = join(tmpdir(), randomUUID());
+    context.path = join(tmpdir(), randomBytes(4).toString('hex'));
   }
 
   await fs.mkdir(context.path, { recursive: true });

diff --git a/test/test-temp-directory.js b/test/test-temp-directory.js
@@ -41,7 +41,7 @@ test('tempDirectory.create --tmpDir:', async (t) => {
   t.plan(2);
   await tempDirectory.create(contextTmpDir);
   t.ok(
-    contextTmpDir.path.match(/thisisatest[/\\].*-.*-.*-.*-.*/),
+    contextTmpDir.path.match(/thisisatest[/\\][0-9a-f]{8}/),
     'the path should match --tmpDir'
   );
   const stats = await fs.stat(contextTmpDir.path);