Skip to content

Commit

Permalink
tools: revert to use @stylistic/eslint-plugin-js v3
Browse files Browse the repository at this point in the history
@stylistic/eslint-plugin-js v4 has been updated to ship ESM-only,
which needs require(esm) support due to the monkey-patching
we do in our eslint.config.mjs. The node-test-linter job in Jenkins
still runs Node.js v20 which has not yet released unflagging
of require(esm). Revert to use v3 for now until we upgrade the
Node.js version used in the CI.

PR-URL: #57314
Refs: #57261
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
  • Loading branch information
joyeecheung authored Mar 4, 2025
1 parent db00f94 commit e05756f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions tools/eslint/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/eslint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"@babel/eslint-parser": "^7.26.8",
"@babel/plugin-syntax-import-attributes": "^7.26.0",
"@babel/plugin-syntax-import-source": "^7.25.9",
"@stylistic/eslint-plugin-js": "^4.1.0",
"@stylistic/eslint-plugin-js": "^3.0.1",
"eslint": "^9.21.0",
"eslint-formatter-tap": "^8.40.0",
"eslint-plugin-jsdoc": "^50.6.3",
Expand Down

0 comments on commit e05756f

Please sign in to comment.