Missing Http2ServerResponse.setHeaders() fixed

[Imperat]

This fixes missing setHeaders:

• Missing Http2ServerResponse.setHeaders() #51573

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/http2
• @nodejs/net

[meyfa]

Suggested change

	`headers` must be an instance of [`Headers`][] or `Map`,
	if a header already exists in the to-be-sent headers,
	`headers` must be an instance of [`Headers`][] or `Map`.
	If a header already exists in the to-be-sent headers,

[Imperat]

Thanks for the feedback 🙌
Fixed here

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56933/

[mcollina]

Can you fix linting and the first commit message?

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[avivkeller]

(waiting for action from author)

[jakecastelli]

Funny enough this PR's github action got stuck for some reasons and therefore stall action to close the PR never happened. Since this is an oz fellow, I reached out to him to see if he's still interested to continue his PR, if not I will manually close it.

update: @Imperat replied to me and still interested to move the PR forward 👍

[Imperat]

Hi @jakecastelli @mcollina
Thanks for having a look at this PR 🙏
I've updated linting, merged the latest main branch and applied suggestions from @meyfa

Hi @mcollina

Can you fix linting and the first commit message?

Do you have a link to a doc describing how should look the commit message? I did not find anything relevant in docs.

[jakecastelli]

Hi @Imperat, first commit message was referred to the project contributing commit guideline. In this PR, the subsystem should be http2 and the commit could be http2: add missing setHeaders (just a suggestion).

Also, the project requires rebase than merge, would you mind rebasing instead of merging and squash your changes into a single commit before you fix the first commit message, if you need any help please let me know.

[avivkeller]

Funny enough this PR's github action got stuck for some reasons and therefore stall action to close the PR never happened. Since this is an oz fellow

FWIW #54425

[codecov]

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.32%. Comparing base (e4f61de) to head (7886934).
Report is 4 commits behind head on main.

Files	Patch %	Lines
lib/internal/http2/compat.js	78.94%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #51576      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         648      648              
  Lines      182321   182340      +19     
  Branches    34971    34981      +10     
==========================================
+ Hits       159222   159223       +1     
- Misses      16374    16388      +14     
- Partials     6725     6729       +4     

Files	Coverage Δ
lib/internal/http2/compat.js	96.50% <78.94%> (-0.34%)	⬇️

... and 25 files with indirect coverage changes