module: add --experimental-strip-node-modules flag #57229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
himself65
approved these changes
Feb 27, 2025
| @@ -1113,6 +1113,16 @@ added: | |||
|
|
|||
| Use this flag to enable [ShadowRealm][] support. | |||
|
|
|||
| ### `--experimental-strip-node-modules` | |||
There was a problem hiding this comment.
When I first read the PR title, I thought this referred to stripping out references to node_modules from stack traces. Maybe I'm the only one who would ever think that, but perhaps this could be clearer even if it becomes more verbose?
Suggested change
| ### `--experimental-strip-node-modules` | |
| ### `--experimental-strip-types-in-node-modules` |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57229 +/- ##
=======================================
Coverage 90.26% 90.27%
=======================================
Files 630 630
Lines 184690 184696 +6
Branches 36142 36145 +3
=======================================
+ Hits 166712 166728 +16
- Misses 11021 11022 +1
+ Partials 6957 6946 -11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #57215